Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve tests for some seq APIs #515

Merged
merged 1 commit into from
Jun 20, 2018
Merged

Improve tests for some seq APIs #515

merged 1 commit into from
Jun 20, 2018

Conversation

sicking
Copy link
Contributor

@sicking sicking commented Jun 15, 2018

Also has a minor improvement some documentation.

@dhardy
Copy link
Member

dhardy commented Jun 16, 2018

Looks like slice::rotate_left was stabilised in 1.26.0. We're still aiming for compatibility with 1.22.0.

@sicking
Copy link
Contributor Author

sicking commented Jun 16, 2018 via email

@dhardy
Copy link
Member

dhardy commented Jun 17, 2018

To be fair, we will update the compiler version at some point, though possibly not soon. If it's not easy you could just disable that test for now.

@dhardy dhardy merged commit 584f2ef into rust-random:master Jun 20, 2018
@dhardy dhardy mentioned this pull request Jun 20, 2018
Closed
28 tasks
@sicking sicking deleted the seq_tests branch June 21, 2018 08:13
@sync-by-unito sync-by-unito bot mentioned this pull request Dec 15, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sicking @dhardy